Skip to content

Fix update notification issue #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 9, 2022
Merged

Fix update notification issue #240

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
07d60b2
set update config if update is available
Feb 3, 2022
d7ba65e
added logic to check for updates on first run
Feb 4, 2022
b0e2823
added code comments
Feb 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions bin/commands/runs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,9 +324,23 @@ module.exports = function run(args, rawArgs) {
utils.sendUsageReport(bsJsonData, args, err.message, Constants.messageTypes.ERROR, utils.getErrorCodeFromErr(err), null, rawArgs);
process.exitCode = Constants.ERROR_EXIT_CODE;
}).finally(function(){
updateNotifier({
const notifier = updateNotifier({
pkg,
updateCheckInterval: 1000 * 60 * 60 * 24 * 7,
}).notify({isGlobal: true});
});

// Checks for update on first run.
// Set lastUpdateCheck to 0 to spawn the check update process as notifier sets this to Date.now() for preventing
// the check untill one interval period. It runs once.
if (!notifier.disabled && Date.now() - notifier.config.get('lastUpdateCheck') < 50) {
notifier.config.set('lastUpdateCheck', 0);
notifier.check();
}

// Set the config update as notifier clears this after reading.
if (notifier.update && notifier.update.current !== notifier.update.latest) {
notifier.config.set('update', notifier.update);
notifier.notify({isGlobal: true});
}
});
}