trim /text()[1] from xpaths
#826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c2800ba The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
seanmcguire12
added
act
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added new trimTrailingTextNode utility function to fix text node interaction issues in XPath selectors, improving element targeting reliability.
- Added new function in
lib/utils.tsto remove/text()[1]from XPath selectors, preventing invalid Playwright operations - Modified
lib/handlers/observeHandler.tsto use the new function when processing accessibility tree StaticText nodes - Fix ensures Playwright targets parent elements instead of text nodes for interactions
- Solution specifically addresses issue #824 where LLM was selecting StaticText nodes incorrectly
2 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
miguelg719
approved these changes
Jun 24, 2025
Merged
seanmcguire12
pushed a commit
that referenced
this pull request
Jun 25, 2025
# Releases ## @browserbasehq/[email protected] ### Minor Changes - [#819](#819) [`6a18c1e`](6a18c1e) Thanks [@seanmcguire12](https://github.com/seanmcguire12)! - try playwright click and fall back to JS click event ### Patch Changes - [#826](#826) [`124e0d3`](124e0d3) Thanks [@seanmcguire12](https://github.com/seanmcguire12)! - fix issue where we are unable to take actions on text nodes - [#818](#818) [`1660751`](1660751) Thanks [@miguelg719](https://github.com/miguelg719)! - Added CUA support for Claude 4 models - [#821](#821) [`cadac9d`](cadac9d) Thanks [@seanmcguire12](https://github.com/seanmcguire12)! - use playwright instead of playwright test - [#832](#832) [`759da55`](759da55) Thanks [@miguelg719](https://github.com/miguelg719)! - Fix \_refreshPageFromAPI to use parametrized apiKey - [#810](#810) [`a175a51`](a175a51) Thanks [@miguelg719](https://github.com/miguelg719)! - Update logos - [#822](#822) [`8527a80`](8527a80) Thanks [@miguelg719](https://github.com/miguelg719)! - Add model with date tag for OpenAI CUA - [#833](#833) [`55fca2f`](55fca2f) Thanks [@seanmcguire12](https://github.com/seanmcguire12)! - adjust stagehandLogger.warn() level to be 1 instead of 0 ## @browserbasehq/[email protected] ### Patch Changes - [#831](#831) [`5812b02`](5812b02) Thanks [@seanmcguire12](https://github.com/seanmcguire12)! - added -man & -h commands for explaining how to run evals - Updated dependencies \[[`124e0d3`](124e0d3), [`6a18c1e`](6a18c1e), [`1660751`](1660751), [`cadac9d`](cadac9d), [`759da55`](759da55), [`a175a51`](a175a51), [`8527a80`](8527a80), [`55fca2f`](55fca2f)]: - @browserbasehq/[email protected] ## @browserbasehq/[email protected] ### Patch Changes - Updated dependencies \[[`124e0d3`](124e0d3), [`6a18c1e`](6a18c1e), [`1660751`](1660751), [`cadac9d`](cadac9d), [`759da55`](759da55), [`a175a51`](a175a51), [`8527a80`](8527a80), [`55fca2f`](55fca2f)]: - @browserbasehq/[email protected] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why
what changed
trimTrailingTextNodewhich trims the text node from the xpathtest plan
act,observe,targeted_extract,combination,regression