handle reroute for rollout

[miguelg719]

why

what changed

test plan

[changeset-bot]

🦋 Changeset detected

Latest commit: b0125a0

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[kamath]

this is a little unintuitive -- having a true/false field for apiEnabled from the API would be cleaner than a true/undefined unavailable field

[cursor]

Bug: Session ID Inconsistency and Type Violation

The API client sets its internal this.sessionId property before checking the unavailable flag in the response data. If unavailable is true, the sessionId in the returned data is set to undefined, but this.sessionId retains the original value. This creates an inconsistent state where the client instance holds a stale session ID, potentially causing subsequent API calls to use an invalid ID. Additionally, setting sessionResponseBody.data.sessionId to undefined violates the StartSessionResult type contract which expects sessionId to be a string.

lib/api.ts#L92-L100

stagehand/lib/api.ts

Lines 92 to 100 in b408393

	this.sessionId = sessionResponseBody.data.sessionId;
	// Temporary reroute for rollout
	if (sessionResponseBody.data?.unavailable) {
	sessionResponseBody.data.sessionId = undefined;
	}
	return sessionResponseBody.data;

Fix in Cursor

---

BugBot free trial expires on June 9, 2025
You have used $0.00 of your $50.00 spend limit so far. Manage your spend limit in the Cursor dashboard.

Was this report helpful? Give feedback by reacting with 👍 or 👎

[greptile-apps]

PR Summary

This PR adds session availability handling for a rollout feature, but needs fixes to maintain API client state consistency and type safety.

• The init() method in lib/api.ts should clear this.sessionId when available is false to maintain consistency with returned data
• Add type guard or assertion to ensure sessionResponseBody.data.sessionId is always a string when available is true
• Consider adding error handling for API calls when this.sessionId is undefined
• Add documentation for the available flag behavior in types/api.ts

_{3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile}