Fix readme logo link #783
Merged
Fix readme logo link #783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 50f7007 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Updated the README.md logo source to use Next.js's image optimization service instead of a direct SVG link.
- Logo source now uses Next.js's image optimization with specific width (384px) and quality (75%) parameters
- Consider adding
alttext to improve accessibility of the logo image - Verify that the dark mode source (
logo-dark.svg) still functions correctly with the media query - Ensure the new
.webpformat is supported across all target platforms/browsers - Double check that the absolute URL
www.stagehand.devis the intended domain vs juststagehand.dev
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
README.md
Outdated
Comment on lines
5
to
6
| <source media="(prefers-color-scheme: dark)" srcset="https://stagehand.dev/logo-dark.svg" /> | ||
| <img alt="Stagehand" src="https://stagehand.dev/logo-light.svg" /> | ||
| <img alt="Stagehand" src="https://www.stagehand.dev/_next/image?url=%2Flogos%2Fmain-logo.webp&w=384&q=75" /> |
There was a problem hiding this comment.
style: Dark mode logo source remains unchanged while light mode uses a different domain (www vs non-www) and format (svg vs webp). This inconsistency could cause maintenance issues.
seanmcguire12
approved these changes
May 29, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why
what changed
test plan