don't log deprecation warning if onlyVisible is undefined
#740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b4dabec The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Removed the default value for onlyVisible parameter in observe() method to prevent unnecessary deprecation warnings when the parameter is not explicitly defined by users.
- Modified
lib/StagehandPage.tsto remove defaultfalsevalue foronlyVisibleparameter - Updated logging logic to only include
onlyVisiblefield when explicitly defined - Maintains backward compatibility while reducing noise in logs
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
miguelg719
approved these changes
May 8, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why
onlyVisible, even if the user does not define itwhat changed
onlyVisibleinStagehandPage.tsso that it remains undefined if the user does not define ittest plan