Skip to content

Fix/scroll scroll to end #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 5, 2025
Merged

Fix/scroll scroll to end #555

merged 2 commits into from
Mar 5, 2025

Conversation

seanmcguire12
Copy link
Member

why

  • we used to calculate the scrollHeight dynamically within each chunk. this meant that when we were chunking, if there was dynamically loaded content, we would not prematurely stop chunking (because we were recalculating this value every chunk)

what changed

  • i added this behaviour back for the case where we do not have a defined candidateElementContainer
  • this means that we continuously update the chunk end condition when we are collecting elements from the entire DOM

Copy link

changeset-bot bot commented Mar 5, 2025

🦋 Changeset detected

Latest commit: ff271a6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@browserbasehq/stagehand Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@seanmcguire12 seanmcguire12 merged commit fc5e8b6 into main Mar 5, 2025
11 checks passed
@github-actions github-actions bot mentioned this pull request Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants