fix tmp user contexts #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5a839da The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
accidentally brought code from other PR
This reverts commit 1963130.
|
Have you tried running this with caching? My concern is primarily around that; we use the |
|
Can test shortly, though in theory it shouldn't have any effect on LLM caching as they create separate sub directories |
|
Works smoothly as tested with the example script after enabling caching @kamath |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why
Current handling causes errors on Windows, this PR makes handling consistent on both OS.
what changed
Ensured the
tmpfolder is created in within the project directory, and used thepathmodule to ensure it works cross-platform.test plan
Run evals on Windows and Mac. Can confirm it's running well on Windows. I don't have access to a MacOS system atm, so that needs to be tested.