Octal string escapes don't seem to work, should this slice from zero?

[gfbee]

pyret-lang/src/js/base/pyret-tokenizer.js

Line 65 in 2af42d6

else { ret += String.fromCharCode(parseInt(esc.slice(2), 8)); }

[blerner]

Thanks for noticing! (It appears we haven't ever had any uses of these escape sequences to notice that this was busted...) Yeah, it appears it doesn't need to slice at all. If you'd like to open a PR to fix it, go ahead: you should base the PR off the horizon branch, and you should add tests to tests/parse/parse.js, e.g. expect(parse("\\101")).toBe("A"); and others, to confirm that the escape sequences are all working properly.

[gfbee]

I appreciate the invitation to fix, but will have to leave that for someone else.

[jpolitz]