provide pie-chart, bar-chart, dot-plot, labeled-dot-plot, E #596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- define & provide E to prevent users using E casually
jpolitz
reviewed
Aug 14, 2025
src/web/arr/trove/dcic2024.arr
Outdated
| end | ||
| end | ||
|
|
||
| E = ~2.718281828459045 |
There was a problem hiding this comment.
I think this is defined in constants, right?
There was a problem hiding this comment.
Yes, however dcic2024.arr includes essentials2024.arr, which already sources constants.arr but deliberately only takes PI.
Ideally we should change essentials2024.arr to also take E from constants.arr, but I didn't want to disturb anything there, especially if there is user code that uses E as a regular variable (i.e., without shadow).
There was a problem hiding this comment.
But in this context can't you just import constants as C and then provide from C: E end?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.