Skip to content

Add tests for collection args with ranges. #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add tests for collection args with ranges. #44

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5f46a61
Add tests for bounded collection args.
cmnbroad Feb 27, 2017
d27c612
Add support and tests for initial value out of range.
cmnbroad Mar 1, 2017
01a7a8c
Add test for simple reset of unbounded list using null
cmnbroad Mar 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/test/java/org/broadinstitute/barclay/argparser/CommandLineArgumentParserTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,6 +534,22 @@ class CollectionWithDefaultValuesArguments {

}

// Should be able to use null to reset a list (with no ranges specified) to empty
@Test
public void testResetListToNull() {
class ResetListToNull {
@Argument
public List<String> LIST = makeList("foo", "bar");
Copy link
Contributor

@magicDGS magicDGS Mar 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will use instead a numeric list to check that this is correct. That was one of my bugs (see #41) and maybe it is better to be sure that it is not broken also for collections.

}
final ResetListToNull o = new ResetListToNull();
final CommandLineArgumentParser clp = new CommandLineArgumentParser(o);
final String[] args = {"--LIST","null"};
Assert.assertTrue(clp.parseArguments(System.err, args));
Assert.assertTrue(o.LIST.isEmpty());
}

// Can't use null to reset a list if there are also other values specified (other values automatically
// reset the list).
@Test(expectedExceptions = CommandLineException.class)
public void testClearDefaultValuesFromListArgumentAndAddNew() {
final CollectionWithDefaultValuesArguments o = new CollectionWithDefaultValuesArguments();
Expand All @@ -543,6 +559,7 @@ public void testClearDefaultValuesFromListArgumentAndAddNew() {
Assert.assertEquals(o.LIST, makeList("baz", "frob"));
}

// Replace the initial values in a list with new values
@Test
public void testReplaceListArgument() {
final CollectionWithDefaultValuesArguments o = new CollectionWithDefaultValuesArguments();
Expand Down