Skip to content

Conversation

yangmillstheory
Copy link

Just minor bugs - should be evident in the changeset.

Also, I took the liberty of:

  • making sure the "gallery" text for Fuji-X100 doesn't overflow into the adjacent product
  • making sure that the product icons appear; previously they weren't

Before:
image

After:
Without hover:
image

On hover:
image

I haven't read through the chapter on testing yet, so I'm wondering if the tests are passing. Could you let me know how to check them?

Thanks for writing the book!

@yangmillstheory yangmillstheory changed the title Fixes for listing 5.3 in Chapter 5. Fixes for listings 5.3, 5.10 in Chapter 5. Oct 12, 2014
@boundvariable
Copy link
Owner

Thanks for the PRs. I haven't forgotten about them. Will go through them next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants