build-sys: Try testing alma 10.0 instead #155
Conversation
We're consistently hitting timeouts in CI, I haven't tried to debug it yet. Let's see if 10.0 is better. Signed-off-by: Colin Walters <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Justfile to use almalinux-bootc:10.0 instead of 9.6 for integration tests. This is an attempt to resolve CI timeouts, and the change is clear and includes a helpful TODO comment linking to the relevant issue. My review provides one suggestion regarding the process: for temporary experiments like this, it's often better to override variables via the command line in the CI configuration rather than modifying the build file. This improves maintainability by keeping the repository's main branch free of temporary debugging code.
| # TODO: Readd quay.io/almalinuxorg/almalinux-bootc:9.6 here after debugging | ||
| # <https://github.com/bootc-dev/bcvk/issues/153> | ||
| ALL_BASE_IMAGES := "quay.io/fedora/fedora-bootc:42 quay.io/centos-bootc/centos-bootc:stream9 quay.io/centos-bootc/centos-bootc:stream10 quay.io/almalinuxorg/almalinux-bootc:10.0" |
There was a problem hiding this comment.
While this change is fine for debugging, committing temporary changes with TODOs to the main branch can lead to maintenance overhead. A potentially better approach for temporary experiments in CI is to override the variable from the CI script itself, if your CI setup allows for it. For example:
just ALL_BASE_IMAGES="quay.io/fedora/fedora-bootc:42 quay.io/centos-bootc/centos-bootc:stream9 quay.io/centos-bootc/centos-bootc:stream10 quay.io/almalinuxorg/almalinux-bootc:10.0" test-integrationThis keeps the Justfile clean, representing the stable, intended configuration, and avoids having to revert this change later.
1 participant
We're consistently hitting timeouts in CI, I haven't tried to debug it yet. Let's see if 10.0 is better.