feat!: move to esm-only #246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ccc9b17 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Open in Stackblitz • @example/basic • @example/changesets commit: |
43081j
commented
Mar 9, 2025
| node-version: 20 | ||
| cache: "pnpm" | ||
| - run: pnpm install | ||
| - run: pnpm build |
Collaborator
Author
There was a problem hiding this comment.
I'm guessing this worked before because we used bundler resolution which basically tells typescript not to care so much about unresolved imports
natemoo-re
approved these changes
Mar 18, 2025
Member
natemoo-re
left a comment
natemoo-re
left a comment
There was a problem hiding this comment.
LGTM! Just going to hold off on merging until #250 lands.
Migrates to emitting only ES modules now that `require(esm)` is supported in all LTS versions of node other than the soon-to-die-off 18.x.
Otherwise the `core` package won't have a `dist/` output to resolve DTS files during `tsc`.
natemoo-re
force-pushed
the
esm-only-maybe
branch
from
3bbd99a to
41f359a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates to emitting only ES modules now that
require(esm)is supported in all LTS versions of node other than the soon-to-die-off 18.x.