goog.forwardDeclare is deprecated

[xvilo]

The goog.forwardDeclare function is deprecated and is actively cleaned up with goog.requireType. When building with version v20200614 (June 17th 2020), you'll get the following erros:

/closure/goog/events/eventhandler.js:55: ERROR - [JSC_MISSING_MODULE_OR_PROVIDE] Required namespace "goog.events.EventWrapper" never defined.
  55| goog.requireType('goog.events.EventWrapper');
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

/closure/goog/events/events.js:57: ERROR - [JSC_MISSING_MODULE_OR_PROVIDE] Required namespace "goog.events.EventWrapper" never defined.
  57| goog.requireType('goog.events.EventWrapper');
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

2 error(s), 0 warning(s)

Currently the last supported Google Closure Library by Plovr is v20200517 (May 19th 2020). I do not have enough knowledge about Plovr's internals to easily fix this and I hope someone can look into this.

[xvilo]

For what I could find out:

• It has been added to the 'regular' regex here: https://github.com/google/closure-compiler/blob/358f715bcbc7f46a2d36194be5781fd7f3860942/src/com/google/javascript/jscomp/deps/JsFileRegexParser.java#L48
• There is an check for requireType and will then add the type dependency to another List https://github.com/google/closure-compiler/blob/358f715bcbc7f46a2d36194be5781fd7f3860942/src/com/google/javascript/jscomp/deps/JsFileRegexParser.java#L334
  • List definition: https://github.com/google/closure-compiler/blob/358f715bcbc7f46a2d36194be5781fd7f3860942/src/com/google/javascript/jscomp/deps/JsFileRegexParser.java#L109
  • This will be added to the dependencyInfo object: https://github.com/google/closure-compiler/blob/358f715bcbc7f46a2d36194be5781fd7f3860942/src/com/google/javascript/jscomp/deps/JsFileRegexParser.java#L217

[xvilo]

@nicks any ideas on this?

[xvilo]

It seems that @unbe has some support added to their fork. I will check if we can use this in our case too! https://github.com/unbe/plovr

@unbe can you let us know if you plan to upstream your changes?

[unbe]

Hey @xvilo, I do not plan to upstream, I just needed it for a quick one-off task. Naturally, feel free to use anything from my fork if that helps in any way.