Fixed ngrok persistence support PR #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ss if persistence key is present
Decomposed the start method for maintainability and clarity.
Fix `line.end_with?` to receive the `addr` in an interpolated String, because if `addr` is an Integer, `end_with?` is failing with a `No implicit conversion of Integer into String` error.
…d of the volatile `/tmp/`
Refactored `store_new_ngrok_process` to use direct `File.write` instead of File.open { |f| f.write }
…ence. Added '#start' method unit tests.
|
@bogdanovich, could you, please, review this PR? |
…ory, instead of `/tmp` volatile folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a second stab at enabling ngrok persistence support, based on the #11 by @scottmartinnet
Is now correctly working, launching ngrok as a background process if persistence key is present