Fix keep duplicate -runbundles #6537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisrueger
force-pushed
the
6526-fix-resolution-removes-duplicates
branch
from
a892536 to
0f97170
Compare
kriegfrj
reviewed
Mar 25, 2025
biz.aQute.resolve/test/biz/aQute/resolve/RunResolutionTest.java
Outdated
Show resolved
Hide resolved
kriegfrj
reviewed
Mar 25, 2025
biz.aQute.resolve/test/biz/aQute/resolve/RunResolutionTest.java
Outdated
Show resolved
Hide resolved
|
i am ok with this |
this fixes the problem that in a RunResultion which suggested the same bundle but in different versions only one bundle (the highest) was kept. Now both suggestions are kept. The problem was that Parameters.toParameter() used parameters.put() instead of parameters.add(). .put() removes duplicate keys, .add() keeps duplicates by using the duplicate markers. Signed-off-by: Christoph Rueger <[email protected]>
chrisrueger
force-pushed
the
6526-fix-resolution-removes-duplicates
branch
from
0f97170 to
83a3854
Compare
kriegfrj
requested changes
Mar 25, 2025
chrisrueger
added a commit
to chrisrueger/bnd
that referenced
this pull request
Mar 28, 2025
based on suggestion in bndtools#6537 (comment) etc Signed-off-by: Christoph Rueger <[email protected]>
chrisrueger
added a commit
that referenced
this pull request
Mar 28, 2025
some forgotten tweaks from last PR #6537 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6526
this fixes the problem that in a RunResultion which suggested the same bundle but in different versions only one bundle (the highest) was kept. Now both suggestions are kept.
The problem was that Parameters.toParameter() used parameters.put() instead of parameters.add(). .put() removes duplicate keys, .add() keeps duplicates by using the duplicate markers.