Skip to content

[PM-24263] Pin protected key envelope unlock #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: km/beeep/safe-password-protected-key-envelope
Choose a base branch
from

Conversation

quexten
Copy link
Contributor

@quexten quexten commented Jul 31, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-24263

📔 Objective

Adds enrollment functionality for Password(PIN)Protected user key envelope. Both crypto initialization via the init request, and a function exposing the raw key material are provided. The latter is required since unlock is not yet done via the init methods on WASM/clients.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Jul 31, 2025

Logo
Checkmarx One – Scan Summary & Details3e369ecb-6aba-407f-ac57-cd5aaed5aaa3

Great job! No new security vulnerabilities introduced in this pull request

@quexten quexten changed the title Km/pin unlock [PM-24263] Pin protected key envelope unlock Jul 31, 2025
@quexten quexten marked this pull request as ready for review August 13, 2025 11:47
@quexten quexten requested review from a team as code owners August 13, 2025 11:47
@quexten quexten requested review from dani-garcia, mzieniukbw and coroiu and removed request for a team and dani-garcia August 13, 2025 11:47
Copy link

Copy link
Contributor

@coroiu coroiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I don't have a ton of experience with the key store. Let me know if there's anything you'd like me to take a deeper look at!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants