-
Notifications
You must be signed in to change notification settings - Fork 79
[PM-18414] CI restructuring #3 - Add Brewfile #1525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
KatherineInCode
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part of me wonders if we should put the brew bundle in the bootstrap.sh script, so that when someone clones the repo we just say run that script and it'll install everything necessary? Though that could get tedious with how often we run that script when e.g. switching branches and such.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1525 +/- ##
==========================================
- Coverage 89.68% 85.95% -3.74%
==========================================
Files 777 988 +211
Lines 48965 59221 +10256
==========================================
+ Hits 43916 50902 +6986
- Misses 5049 8319 +3270 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Great job, no security vulnerabilities found in this Pull Request |
c00f9e9 to
1cfe82f
Compare
@KatherineInCode Initially had that but ended up scrapping it, it would slow things down for everyone. But there's a
|
KatherineInCode
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the brew bundle check! Looks good to me!

🎟️ Tracking
PM-18414
📔 Objective
Splitting this change from the bigger CI restructuring branch.
Address a recurring dev experience gap by having a list of homebrew dependencies that can be used by our devs locally and in our CI - dependencies were regularly missed while setting up local dev environments.
Also looked into pinning dependency versions, we would need to create our own tap. References:
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes