Skip to content

BIP352: fix byte unpacking and avoid mutable default argument #1916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

BIP352: fix byte unpacking and avoid mutable default argument #1916

wants to merge 2 commits into from
+8 −8

Conversation

fifalodm
Copy link

@fifalodm fifalodm commented Aug 8, 2025

  • Fixed deser_compact_size to correctly unpack the first byte instead of reading twice.

  • Updated scanning to use Optional[Dict] with safe default (None → {}) to prevent mutable default argument issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Proposed BIP modification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fifalodm @jonatack