BIP32: edits by ddustin for clarity #1903
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatack
added
Proposed BIP modification
Pending acceptance
jonatack
changed the title
There was a problem hiding this comment.
Compared to #785 and found to match the old pull request in combination with the outstanding review comments from the BIPs authors except for the mentioned spot.
Co-authored-by: Jon Atack <[email protected]> Co-authored-by: Murch <[email protected]>
jonatack
force-pushed
the
2025-07-PR785-ddustin-edits-to-BIP32
branch
from
3fa6bc7 to
879066d
Compare
|
@sipa: Could you take another look at these few lines? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picks up @ddustin's work in #785, updated with the latest reviewers' feedback.