Don't fail JNI dependency checks if we can build a JNI program #466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all setups will result in JNI_INCLUDE_DIRS having a value, in particular Android builds from standalone toolchain directories have the JNI headers installed in the standard include directories. Instead of failing if the configure macro didn't find a directory based on the installed Java runtime, only fail if we cannot build a JNI-including program.
gmaxwell
approved these changes
Jul 11, 2017
Contributor
gmaxwell
left a comment
gmaxwell
left a comment
There was a problem hiding this comment.
Looks good to me. utACK
Contributor
|
@theuni Care to have a look? |
Contributor
|
This can re-enable jni if it's been turned off because ecdh is disabled. I think the quick fix is just to move the |
Contributor
|
Closing this because we removed the JNI bindings in #682. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all setups will result in JNI_INCLUDE_DIRS having a value, in
particular Android builds from standalone toolchain directories have
the JNI headers installed in the standard include directories.
Instead of failing if the configure macro didn't find a directory
based on the installed Java runtime, only fail if we cannot build a
JNI-including program.