-
Notifications
You must be signed in to change notification settings - Fork 59
A few improvements to prepare for subtree in Bitcoin Core #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc @sipsorcery |
|
I believe |
I used For other projects I usually use I personally have no objections to either using |
|
I believe that _WIN32 is set by the compiler on windows, WIN32 is only set if you have some header that sets it or a build environment that does. Googling around I see commits in some open source projects changing from WIN32 to _WIN32, and I see that some projects check for either or. I don't see any changing from _WIN32 to WIN32. So I think checking if either is set or just checking _WIN32 alone is the most reliable choice. As far as bitcoin core goes, it has a relatively limited support of build environments, so whatever works is fine. It's better though if library code tends to be more portable. |
|
Changed to _WIN32, and also switched |
4809cc9 to
4721111
Compare
|
utACK 4721111 this should be tested by someone on MSVC. |
|
I'm testing this in bitcoin/bitcoin#21859, so still making changes. |
5095597 to
c03320f
Compare
371d170 to
ace43f2
Compare
5d26cc6 to
20f1136
Compare
d37e09f to
ee197e0
Compare
|
This is ready. |
|
utACK 1e96b67 (I also tested it, but not with mingw or msvc, so it doesn't count) |
|
okay, I tested mingw32 too. |
This includes various build system and compatibility improvements discovered in the process of subtreeing this into Bitcoin Core (see bitcoin/bitcoin#21859).