Skip to content

Address clang-tidy-19 warnings #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from
Closed

Address clang-tidy-19 warnings #144

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
a692038
cmake: Skip linting for generated sources
hebasto Jan 31, 2025
3c07ab8
clang-tidy: Disable `misc-use-anonymous-namespace` check
hebasto Jan 31, 2025
d6523b6
clang-tidy: Disable `performance-avoid-endl` check
hebasto Jan 31, 2025
1cc0bf5
clang-tidy: Fix `bugprone-crtp-constructor-accessibility` check
hebasto Jan 31, 2025
5a15744
clang-tidy: Suppress `bugprone-empty-catch` check warning
hebasto Jan 31, 2025
f983b09
clang-tidy: Fix `modernize-type-traits` check
hebasto Jan 31, 2025
06806fe
clang-tidy: Fix `misc-const-correctness` check
hebasto Jan 31, 2025
90cb5a9
clang-tidy: Fix `misc-include-cleaner` check
hebasto Jan 31, 2025
2ad6c17
clang-tidy: Fix `misc-use-internal-linkage` check
hebasto Jan 31, 2025
584f3e2
clang-tidy: Fix `performance-unnecessary-value-param` check
hebasto Jan 31, 2025
fa265a9
clang-tidy: Fix `readability-avoid-nested-conditional-operator` check
hebasto Jan 31, 2025
f159c75
clang-tidy: Fix `readability-avoid-return-with-void-value` check
hebasto Jan 31, 2025
3418ad2
clang-tidy: Fix `readability-container-size-empty` check
hebasto Jan 31, 2025
19d7537
clang-tidy: Suppress `performance-enum-size` check warning
hebasto Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion example/calculator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,15 @@
#include <calculator.h>
#include <fstream>
#include <init.capnp.h>
#include <init.capnp.proxy-types.h>
#include <init.capnp.proxy.h> // NOLINT(misc-include-cleaner)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In commit "clang-tidy: Fix misc-include-cleaner check" (90cb5a9)

Is the include-cleaner check not compatible with IWYU? When I ran IWYU it seemed to correctly add <init.capnp.proxy.h> include. Do we know if it is expected that clang-tidy would complain about this?

Same applies to other nolint below.

Copy link
Member Author

@hebasto hebasto Feb 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the include-cleaner check not compatible with IWYU?

They seem incompatible.

When I ran IWYU it seemed to correctly add <init.capnp.proxy.h> include.

The include-what-you-use tool built from the clang_19 branch still insist on removing #include <init.capnp.proxy.h>.

It seem both linters fail to parse a convoluted template code properly.

Additionally, IWYU suggests:

#include <kj/async.h>     // for evalLater
#include <kj/common.h>    // for fwd, mv, ctor, implicitCast, instance
#include <kj/memory.h>    // for heap

for this line:https://github.com/chaincodelabs/libmultiprocess/blob/477405eda34d923bd2ba6b3abc4c4d31db84c3ea/example/calculator.cpp#L48

#include <init.h>
#include <iostream>
#include <memory>
#include <mp/proxy-io.h>
#include <printer.h>
#include <stdexcept>
#include <string>
#include <utility>

class CalculatorImpl : public Calculator
{
Expand Down
9 changes: 8 additions & 1 deletion example/example.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,17 @@

#include <filesystem>
#include <fstream>
#include <future>
#include <init.capnp.h>
#include <init.capnp.proxy-types.h>
#include <init.capnp.proxy.h>
#include <iostream>
#include <mp/proxy-io.h>
#include <mp/util.h>
#include <stdexcept>
#include <string>
#include <thread>
#include <tuple>
#include <vector>

namespace fs = std::filesystem;

Expand Down
3 changes: 2 additions & 1 deletion example/printer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,14 @@

#include <fstream>
#include <init.capnp.h>
#include <init.capnp.proxy-types.h>
#include <init.capnp.proxy.h> // NOLINT(misc-include-cleaner)
#include <init.h>
#include <iostream>
#include <memory>
#include <mp/proxy-io.h>
#include <printer.h>
#include <stdexcept>
#include <string>

class PrinterImpl : public Printer
{
Expand Down
11 changes: 11 additions & 0 deletions src/mp/gen.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,22 @@

#include <algorithm>
#include <capnp/schema-parser.h>
#include <cstdint>
#include <cstdio>
#include <cstdlib>
#include <errno.h>
#include <fstream>
#include <functional>
#include <kj/array.h>
#include <kj/common.h>
#include <kj/filesystem.h>
#include <kj/memory.h>
#include <kj/string.h>
#include <map>
#include <set>
#include <sstream>
#include <stdexcept>
#include <string>
#include <system_error>
#include <unistd.h>
#include <vector>
Expand Down
1 change: 1 addition & 0 deletions src/mp/proxy.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
#include <string>
#include <sys/socket.h>
#include <thread>
#include <tuple>
#include <unistd.h>
#include <utility>

Expand Down
11 changes: 6 additions & 5 deletions src/mp/util.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,21 +6,22 @@
#include <mp/util.h>

#include <errno.h>
#include <kj/array.h>
#include <kj/common.h>
#include <kj/string-tree.h>
#include <pthread.h>
#include <sstream>
#include <stdio.h>
#include <string>
#include <sys/resource.h>
#include <sys/socket.h>
#include <sys/types.h>
#include <sys/un.h>
#include <sys/wait.h>
#include <system_error>
#include <thread>
#include <unistd.h>
#include <utility>
#include <vector>

#if __linux__
#include <syscall.h>
#include <sys/syscall.h>
#endif

#ifdef HAVE_PTHREAD_GETTHREADID_NP
Expand Down
9 changes: 8 additions & 1 deletion test/mp/test/test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,22 @@
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.

#include <mp/proxy-types.h>
#include <mp/proxy-io.h>
#include <mp/test/foo.capnp.h>
#include <mp/test/foo.capnp.proxy.h>
#include <mp/test/foo.h>

#include <capnp/capability.h>
#include <cstdio>
#include <future>
#include <functional>
#include <memory>
#include <kj/common.h>
#include <kj/memory.h>
#include <kj/test.h>
#include <string>
#include <thread>
#include <utility>

namespace mp {
namespace test {
Expand Down