Skip to content

Define MAX_DIGITS_BTC for magic number in BitcoinUnits::format #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2020
Merged

Define MAX_DIGITS_BTC for magic number in BitcoinUnits::format #153

merged 1 commit into from
Dec 17, 2020

Conversation

@luke-jr
Copy link
Member

@luke-jr luke-jr commented Dec 15, 2020 •
edited
Loading

A magic number snuck in with bitcoin/bitcoin#16432

@luke-jr luke-jr changed the title GUI: Define MAX_DIGITS_BTC for magic number in BitcoinUnits::format Define MAX_DIGITS_BTC for magic number in BitcoinUnits::format Dec 15, 2020
hebasto
hebasto approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 198fff8, I have reviewed the code and it looks OK, I agree it can be merged.

kristapsk
kristapsk approved these changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@kristapsk kristapsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 198fff8

@maflcko maflcko merged commit d0e76b5 into bitcoin-core:master Dec 17, 2020
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Dec 17, 2020
Merge bitcoin-core/gui#153: Define MAX_DIGITS_BTC for magic number in…
3a230ab
@barton2526 barton2526 mentioned this pull request Aug 1, 2022
Merged
@bitcoin-core bitcoin-core locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hebasto hebasto hebasto approved these changes

+1 more reviewer

@kristapsk kristapsk kristapsk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@luke-jr @kristapsk @hebasto @maflcko