Skip to content

Get new address from selected wallet in receive tab #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: qt6
Choose a base branch
from
Open

Get new address from selected wallet in receive tab #496

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b628681
receivePayment: get new address from wallet
pinheadmz Aug 8, 2025
fb69f11
receivePayment: fix QR code import in new build system
pinheadmz Aug 8, 2025
869585b
receivePayment: clear when switching wallets
pinheadmz Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions qml/pages/wallet/RequestPayment.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,14 @@ Page {
}
}

function clear() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to the root? It is a reasonable function at the component level.

clearRequest.visible = false
title.text = qsTr("Request a payment")
address.text = ""
qrImage.code = ""
continueButton.text = qsTr("Create bitcoin address")
}

ContinueButton {
id: clearRequest
Layout.fillWidth: true
Expand All @@ -221,11 +229,14 @@ Page {
backgroundPressedColor: "transparent"
text: qsTr("Clear")
onClicked: {
clearRequest.visible = false
title.text = qsTr("Request a payment")
address.text = ""
qrImage.code = ""
continueButton.text = qsTr("Create bitcoin address")
columnLayout.clear()
}
}

Connections {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to not rely on walletController, move this to DesktopWallets where walletController is already referenced, add an id to RequestPayment and call clear().

target: walletController
function onSelectedWalletChanged() {
columnLayout.clear()
}
}
}
Expand Down
Loading