Add validation to the Send form (address and amount) #490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MarnixCroes do you mind re-reviewing this change? |
MarnixCroes
reviewed
Aug 6, 2025
There was a problem hiding this comment.
- The
Amount must be greater than zerowhile there is only the placeholder text is a bit silly.
Which can be repro'd by entering 0 and then deleting it.
- The amount sometimes changes and gets negative when entering large numbers:
Screencast.from.2025-08-06.11-11-16.webm
Screencast.from.2025-08-06.11-13-03.webm
| } else if (IsValidDestinationString(m_address.toStdString(), *CChainParams::TestNet())) { | ||
| setAddressError(tr("Address is valid for testnet, not the current network")); | ||
| } else { | ||
| setAddressError(tr("Invalid address format")); |
There was a problem hiding this comment.
Suggested change
| setAddressError(tr("Invalid address format")); | |
| setAddressError(tr("Invalid address")); |
maybe better?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add properties for the error strings used in the QML to SendRecipient and add validation methods that are checked when the relevant properties are changed by the user.
This is a port of #462 into the qt6 branch