impersonation: switch Twitter for X #1135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darosior
approved these changes
May 22, 2025
|
ACK a5bbfbb |
murchandamus
reviewed
Jun 4, 2025
_includes/footer.html
Outdated
| @@ -1,6 +1,6 @@ | |||
| <div> | |||
| <span> | |||
| <a href="https://twitter.com/bitcoincoreorg" target="_blank" class=""><i class="fa fa-fw fa-twitter"></i>Twitter</a><br /> | |||
| <a href="https://x.com/bitcoincoreorg" target="_blank" class=""><i class="fa fa-fw fa-twitter"></i>Twitter</a><br /> | |||
There was a problem hiding this comment.
Should Twitter and the symbol here also be replaced with X?
There was a problem hiding this comment.
I think we'd need to update some CSS to get access to the new fontawesome logo for X, so I've just dropped the twitter icon.
|
Dropped / replaced more Twitter. |
glozow
reviewed
Jun 23, 2025
There was a problem hiding this comment.
nit be032ca: s/lifestyle/lifecycle
azuchi
added a commit
to azuchi/bitcoincore.org
that referenced
this pull request
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove references to Travis.
Update link in lifestyle.