MUI: Update minor version of material UI and Emotion packages #2339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MUI from 5.14.12 to 5.18.0 While not initiated for any known bugs in Bitburner. MUI 5.15.x and 5.16.x contains numerous bug fixes, but doesn't appear to have any breaking changes. [MUI 5.17.0](https://github.com/mui/material-ui/releases/tag/v5.17.0) I believe this doesn't affect us. [MUI 5.17.1](https://github.com/mui/material-ui/releases/tag/v5.17.1) fixes a layout bug. [MUI 5.18.0](https://github.com/mui/material-ui/releases/tag/v5.18.0) is a backport of CSS layers feature from MUI v7. The Emotion package is [updated](https://github.com/emotion-js/emotion/releases) from 11.11.x to 11.14.x, as I believe it is used only in connection with the MUI packages. Again updates appear minor, with no breaking changes noted.
Collaborator
|
I don't see any regression bugs in UI, but I think you need to test the change in I'm not sure why, but when I make the same changes, my How to test:
I tested on 2 machines (Windows 10 + VM Debian 13) with nodejs v22.20.0 and npm 10.9.3. Please test it again on your machine. |
Contributor
Author
|
It is because I made the commit on Sep 26 when react-is@19 was 19.1.1, and then Facebook released React 19.2.0 on Oct 1.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update mui and emotion to current minor versions and patches.
Update Material UI (a React component library that implements Google's Material Design) from 5.14.12 to 5.18.0
This is the most recent release of MUI 5.x.
Material UI v6 does support React 17, but it has some breaking changes, that I suspect may affect us.
This was not initiated for any known bugs in Bitburner, but to reduce the "distance" between the current stable release of Material UI, and our dependencies without introducing breaking changes.
MUI 5.15.x and 5.16.x contains numerous (~12-20) bug fixes, but doesn't appear to have any breaking changes.
MUI 5.17.0 - I believe this doesn't affect us.
MUI 5.17.1 - fixes a layout bug.
MUI 5.18.0 is a backport of CSS layers feature from MUI v7.
The Emotion package for writing CSS using JavaScript / React, is updated from 11.11.x to 11.14.x, as I believe it is used only in connection with the MUI packages. Again updates appear minor; bug fixes, and migrated to using TypeScript, with no breaking changes noted.