Relax NumericType restriction on AbstractSource and RandomAccessibleSources #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ources for non-numeric types, only NearestNeighborInterpolatorFactory is used
axtimwalde
pushed a commit
to axtimwalde/bigdataviewer-vistools
that referenced
this pull request
Feb 6, 2024
…wLogging Implement ViewerTransformLogger and PositionLogger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While not immediately applicable to
BdvFunctions.show(), relaxing theNumericTypeconstraint onAbstractSourceand theRandomAccessibleSourceclasses would be helpful for something likeViewerPanel.addSource(), allowing these convenience classes to be used in those applications as well (i.e. passing aRandomAccessibleInterval<LabelMultisetType>).In the case where
Tis not aNumericType, only theNearestNeighborInterpolatoris used, rather thanDefaultInterpolatorswhich requiresNumericTypeso that it can use both Nearest Neighbor and NLinear.Notably, this solution uses a raw type on
DefaultInterpolators, but I don't know of a much better way to do it.@hanslovsky suggested this change.