Skip to content

Small fixes to Sku and Shipment classes #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Small fixes to Sku and Shipment classes #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4614549
Removed the options() method from Sku class as the 'options' property…
bc-jz Jul 8, 2015
8b0ee6e
Removed 'shipping_methods' from the ignore fields and added 'billing_…
bc-jz Jul 8, 2015
a696b1e
Removed the test of the options() method from SkuTest.php. Deleted S…
bc-jz Jul 9, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/Bigcommerce/Api/Resources/Shipment.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,18 @@ class Shipment extends Resource
'order_id',
'date_created',
'customer_id',
'shipping_method',
'billing_address',
'shipping_address'
);

protected $ignoreOnUpdate = array(
'id',
'order_id',
'date_created',
'customer_id',
'shipping_method',
'items',
'billing_address',
'shipping_address'
);

public function create()
Expand Down
11 changes: 0 additions & 11 deletions src/Bigcommerce/Api/Resources/Sku.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,17 +19,6 @@ class Sku extends Resource
'product_id',
);

public function options()
{
$options = Client::getCollection($this->fields->options->resource, 'SkuOption');

foreach ($options as $option) {
$option->product_id = $this->product_id;
}

return $options;
}

public function create()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd look at keeping this method for backwards compaitability (assuming it returns the same objects), with the implementation @ransomcarroll suggested here: #146 (comment)

{
return Client::createResource('/products/' . $this->product_id . '/skus', $this->getCreateFields());
Expand Down
31 changes: 0 additions & 31 deletions src/Bigcommerce/Api/Resources/SkuOption.php
View file
Open in desktop

This file was deleted.

28 changes: 0 additions & 28 deletions test/Unit/Api/Resources/SkuOptionTest.php
View file
Open in desktop

This file was deleted.

20 changes: 0 additions & 20 deletions test/Unit/Api/Resources/SkuTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,24 +25,4 @@ public function testUpdatePassesThroughToConnection()

$sku->update();
}

public function testOptionsPassesThroughToConnection()
{
$sku = new Sku((object)array(
'product_id' => 1,
'options' => (object)array(
'resource' => '/products/1/skus/1/options'
)
));
$this->connection->expects($this->once())
->method('get')
->with($this->basePath . '/products/1/skus/1/options')
->will($this->returnValue(array(array(), array())));

$collection = $sku->options;
$this->assertInternalType('array', $collection);
foreach ($collection as $condition) {
$this->assertInstanceOf('Bigcommerce\\Api\\Resources\\SkuOption', $condition);
}
}
}