Skip to content

Conversation

@lucanos
Copy link

@lucanos lucanos commented May 6, 2013

Added Minified Version of Plugin.
Renamed files inline with a good portion of jQuery-dependent plugins.

Inline with standard across a good number of jQuery-dependent plugins.
@bgrins
Copy link
Owner

bgrins commented May 6, 2013

Thanks for the interest in the project. I am not sold on renaming the file, as it is directly referenced by that path in a number of places, and the github 404 page leaves something to be desired (no way to navigate through the repository afterwards or set up a redirect).

We can definitely add in the minified version though - which tool did you use for doing the minification?

@lucanos
Copy link
Author

lucanos commented May 6, 2013

I suggest the renaming as it is commonly used across a large number of plugins. (It makes it very simple to organise your dependancies - anything starting jquery. must appear after jquery(.min).js.

I used http://jscompress.com/ to minify the script.

@bgrins
Copy link
Owner

bgrins commented May 6, 2013

I agree that it can make it easier to organize with the jquery prefix. Unfortunately I really don't want all of the incoming links or demos to start 404ing, so it may have to be a manual renaming process. I will pull in the minified file if you can update the PR to remove the renaming. If you make the changes, git add them, then do git commit --amend and git push origin master --force it should keep the history clean and update this PR in place. Let me know if this isn't explained well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants