Only update unused modes when needed #3827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
|
Do you want to test this code? Here you have an automated build: |
haslinghuis
approved these changes
Mar 2, 2024
HThuren
approved these changes
Mar 2, 2024
Contributor
Author
|
It has nothing to do with the outside world, it's merely a GUI thing. Channel value markers and mode on/off states are still updated unconditionally at every 50ms tick |
Member
right, anyway test when mode value change do no harm |
chmelevskij
pushed a commit
to chmelevskij/betaflight-configurator
that referenced
this pull request
Apr 27, 2024
Only touch DOM when needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During review I discovered on the modes tab visible elements are updated every 50ms for no reason. This is a performance improvement to update the modes only when the "Hide unused modes" is toggled.