Skip to content

[Chore] apply lexical scoping to stm32usbdfu #3752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 12, 2024
Merged

[Chore] apply lexical scoping to stm32usbdfu #3752

merged 2 commits into from
Mar 12, 2024

Conversation

@haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Jan 13, 2024

No description provided.

@haslinghuis haslinghuis added this to the 11.0 milestone Jan 13, 2024
@haslinghuis haslinghuis self-assigned this Jan 13, 2024
@github-actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis force-pushed the apply-lexical-scoping branch 2 times, most recently from 12a4d57 to 89cf89b Compare January 14, 2024 00:07
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 14, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

16 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions

This comment has been minimized.

Sign in to view
@haslinghuis
Copy link
Member Author

haslinghuis commented Jan 14, 2024

16 sonar issue to go :)

@blckmn
Copy link
Member

blckmn commented Jan 14, 2024

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis force-pushed the apply-lexical-scoping branch from 89cf89b to de3af4d Compare March 9, 2024 18:55
@haslinghuis
Copy link
Member Author

haslinghuis commented Mar 9, 2024

Rebased.

@github-actions

This comment has been minimized.

Sign in to view
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 9, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2024

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Linux
Betaflight-Configurator-Android
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@nerdCopter
Copy link
Member

nerdCopter commented Mar 12, 2024

6957f334 - flashed FOXEERF405, PYRDRONEF7, SKYSTARSF405AIO without issue.

@haslinghuis haslinghuis merged commit 063e4f5 into betaflight:master Mar 12, 2024
@haslinghuis haslinghuis deleted the apply-lexical-scoping branch March 12, 2024 14:14
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
@haslinghuis @chmelevskij
[Chore] apply lexical scoping to stm32usbdfu (betaflight#3752)
bed3873 
* [Chore] apply lexical scoping to stm32usbdfu

* Remove remaining sonar issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@McGiverGim McGiverGim McGiverGim approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

Assignees

@haslinghuis haslinghuis

Labels

RN: REFACTOR Tested

Projects

None yet

Milestone

2025.12

Development

Successfully merging this pull request may close these issues.

4 participants

@haslinghuis @blckmn @nerdCopter @McGiverGim