Skip to content

Fix language selection #3713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 1, 2024
Merged

Fix language selection #3713

merged 1 commit into from
Jan 1, 2024

Conversation

@haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Dec 31, 2023

No description provided.

@haslinghuis haslinghuis added this to the 10.10.0 milestone Dec 31, 2023
@haslinghuis haslinghuis self-assigned this Dec 31, 2023
@github-actions

This comment has been minimized.

Sign in to view
@blckmn
Copy link
Member

blckmn commented Dec 31, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

blckmn
blckmn reviewed Dec 31, 2023
View reviewed changes
src/js/tabs/landing.js Outdated
});

bottomSection.find('a').each((index) => {
bottomSection.find('a').each(function(index) {
Copy link
Member

@blckmn blckmn Dec 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
bottomSection.find('a').each(function(index) {
bottomSection.find('a').each((index, element) => {

blckmn
blckmn reviewed Dec 31, 2023
View reviewed changes
src/js/tabs/landing.js Outdated

bottomSection.find('a').each((index) => {
bottomSection.find('a').each(function(index) {
let element = $(this);
Copy link
Member

@blckmn blckmn Dec 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let element = $(this);

Copy link
Member Author

@haslinghuis haslinghuis Dec 31, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both suggestions did not work :(

Arrow functions and this don't get along

Reverted and it works again

@haslinghuis haslinghuis force-pushed the fix-language-option branch 2 times, most recently from b20d30e to 91521c0 Compare December 31, 2023 03:10
@github-actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis requested a review from blckmn December 31, 2023 03:22
blckmn
blckmn reviewed Dec 31, 2023
View reviewed changes
src/js/tabs/landing.js Outdated
bottomSection.find('a').each((index) => {
bottomSection.find('a').each(function(index) {
let element = $(this);
element.click(() => {
Copy link
Member

@blckmn blckmn Dec 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
element.click(() => {
$(element).click(() => {

Also need to change this (if passing the param).

Copy link
Member Author

@haslinghuis haslinghuis Dec 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@Pancronos
Copy link

Pancronos commented Dec 31, 2023

This one is ok, can change language.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 31, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions
Copy link
Contributor

github-actions bot commented Dec 31, 2023

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

nerdCopter
nerdCopter approved these changes Dec 31, 2023
View reviewed changes
Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1ebed155 works.

@haslinghuis haslinghuis requested a review from blckmn January 1, 2024 00:16
@haslinghuis haslinghuis merged commit 47e196c into betaflight:master Jan 1, 2024
@haslinghuis haslinghuis deleted the fix-language-option branch January 1, 2024 00:23
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
@haslinghuis @chmelevskij
Fix language selection (betaflight#3713)
f1925cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blckmn blckmn blckmn approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

Assignees

@haslinghuis haslinghuis

Labels

RN: BUGFIX

Projects

Finalizing Firmware 4.5 Release
Status: COMPLETED

Milestone

10.10.0

Development

Successfully merging this pull request may close these issues.

4 participants

@haslinghuis @blckmn @Pancronos @nerdCopter