Skip to content

Fix Android #3708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 31, 2023
Merged

Fix Android #3708

merged 1 commit into from
Dec 31, 2023

Conversation

@haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Dec 30, 2023 •
edited
Loading

Fixes:

image

@haslinghuis haslinghuis added this to the 10.10.0 milestone Dec 30, 2023
@haslinghuis haslinghuis self-assigned this Dec 30, 2023
@haslinghuis haslinghuis marked this pull request as draft December 30, 2023 18:08
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis force-pushed the fix-android branch 2 times, most recently from cc944c1 to bf1241c Compare December 30, 2023 19:01
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis force-pushed the fix-android branch 4 times, most recently from 0001820 to 8dc6b56 Compare December 30, 2023 20:00
@github-actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis force-pushed the fix-android branch 2 times, most recently from adc16d3 to a6cf0e8 Compare December 30, 2023 20:19
@haslinghuis haslinghuis marked this pull request as ready for review December 30, 2023 20:26
@github-actions

This comment has been minimized.

Sign in to view
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 30, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions
Copy link
Contributor

github-actions bot commented Dec 30, 2023

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn
Copy link
Member

blckmn commented Dec 30, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis mentioned this pull request Dec 31, 2023
Merged
@haslinghuis haslinghuis merged commit 3f16b22 into betaflight:master Dec 31, 2023
@haslinghuis haslinghuis deleted the fix-android branch December 31, 2023 16:49
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
@haslinghuis @chmelevskij
Fix Android (betaflight#3708)
d37399f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blckmn blckmn blckmn approved these changes

@chmelevskij chmelevskij chmelevskij approved these changes

@McGiverGim McGiverGim Awaiting requested review from McGiverGim

Assignees

@haslinghuis haslinghuis

Labels

RN: BUGFIX

Projects

Finalizing Firmware 4.5 Release
Status: COMPLETED

Milestone

10.10.0

Development

Successfully merging this pull request may close these issues.

3 participants

@haslinghuis @blckmn @chmelevskij