Skip to content

fix: msp receiver emulator #3706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 30, 2023
Merged

fix: msp receiver emulator #3706

merged 1 commit into from
Dec 30, 2023

Conversation

@chmelevskij
Copy link
Member

@chmelevskij chmelevskij commented Dec 30, 2023

Fixes MSP receiver window

image

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 30, 2023

Quality Gate Failed Quality Gate failed

Failed conditions

14.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@github-actions
Copy link
Contributor

github-actions bot commented Dec 30, 2023

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn
Copy link
Member

blckmn commented Dec 30, 2023 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@SteveCEvans
Copy link
Member

SteveCEvans commented Dec 30, 2023

Now working for me.

image

@haslinghuis haslinghuis added this to the 10.10.0 milestone Dec 30, 2023
McGiverGim
McGiverGim approved these changes Dec 30, 2023
View reviewed changes
Copy link
Member

@McGiverGim McGiverGim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@haslinghuis haslinghuis merged commit a51c0a6 into betaflight:master Dec 30, 2023
chmelevskij added a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
@chmelevskij
fix: msp receiver emulator (betaflight#3706)
a6ea4ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@McGiverGim McGiverGim McGiverGim approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

Assignees

@chmelevskij chmelevskij

Labels

RN: BUGFIX

Projects

Finalizing Firmware 4.5 Release
Status: COMPLETED

Milestone

10.10.0

Development

Successfully merging this pull request may close these issues.

5 participants

@chmelevskij @blckmn @SteveCEvans @McGiverGim @haslinghuis