Skip to content

Conversation

@HThuren
Copy link
Member

@HThuren HThuren commented Nov 1, 2023

Making possible to translate Roll, Pitch, Yaw and Throttle
image

@github-actions

This comment has been minimized.

@blckmn
Copy link
Member

blckmn commented Nov 2, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

Copy link
Member

@McGiverGim McGiverGim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the letter inside the brackets? At the beginning I thought it was some kind of shortcut, but looking at them they form AERT, so is a relation with the TX command, usually used for planes. Has some sense to maintain it here? The Roll, Pitch, Yaw and Throttle I think is enough informative. What others think?

@nerdCopter
Copy link
Member

Please check Sonar-Cloud about surrounding <li> items.
Concur with @McGiverGim , sentiment. looks good, but no clue what servo users expect.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@HThuren
Copy link
Member Author

HThuren commented Nov 2, 2023

The cloud issue are now fixed.
I agree, the letters, looks like AERT order of transmitter pins. There are no logic in code regarding the pin in use.
I found the same setup -also in reciever.js - for

// generate bars
        const bar_names = [
            i18n.getMessage('controlAxisRoll'),
            i18n.getMessage('controlAxisPitch'),
            i18n.getMessage('controlAxisYaw'),
            i18n.getMessage('controlAxisThrottle'),
        ];

Maybe we should left as is ?

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2023

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis
Copy link
Member

haslinghuis commented Nov 2, 2023

AETR is the default order in receiver tab. We should not translate these letters and not sort these.

image

image

@HThuren
Copy link
Member Author

HThuren commented Nov 2, 2023

Agree, then there also are no changes to this PR.
I my danish translation I translate ex "Pitch [E]" to "Højderor [E]" to keep relation to AETR

@haslinghuis haslinghuis added this to the 10.10.0 milestone Nov 2, 2023
@haslinghuis haslinghuis merged commit cf3070a into betaflight:master Nov 6, 2023
@HThuren HThuren deleted the translateReciever branch November 6, 2023 18:20
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
* Translate labels at reciever signal graph

* Fix sonarcloud issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: COMPLETED

Development

Successfully merging this pull request may close these issues.

5 participants