Skip to content

Conversation

@stoneman
Copy link
Contributor

@stoneman stoneman commented Sep 17, 2023

Edit: Description below has been updated. The PR originally updated links in the language files too.

This link is 404ing as there is no /docs directory in the betaflight repo. I'm guessing those docs were moved to betaflight.com so I've updated the link to what I assume is the correct location within https://betaflight.com.

@blckmn
Copy link
Member

blckmn commented Sep 17, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> FAIL
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@HThuren
Copy link
Member

HThuren commented Sep 17, 2023

I belive the language file update must be in Crowdin

@haslinghuis
Copy link
Member

We only need to update en locale. Translations are done using crowdin

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@stoneman
Copy link
Contributor Author

Changes to language files reverted.

For reference, it's the it, pl & pt_BR files that contain out of date links.

@stoneman stoneman changed the title Update links to documentation Update link to documentation in PR template Sep 17, 2023
@HThuren
Copy link
Member

HThuren commented Sep 17, 2023

Changes to language files reverted.

For reference, it's the it, pl & pt_BR files that contain out of date links.

Maybe @McGiverGim can notify the translators (I don't know howto) ?

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis merged commit 173b650 into betaflight:master Sep 19, 2023
@stoneman stoneman deleted the documentation-links branch September 24, 2023 09:58
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: COMPLETED

Development

Successfully merging this pull request may close these issues.

5 participants