Skip to content

feat: added port picker vue component #3543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 30, 2023
Merged

feat: added port picker vue component #3543

merged 2 commits into from
Aug 30, 2023

Conversation

@lipskij
Copy link
Contributor

@lipskij lipskij commented Aug 13, 2023

Added port picker vue components

@haslinghuis haslinghuis added this to the 10.10.0 milestone Aug 13, 2023
@github-actions

This comment has been minimized.

Sign in to view
@blckmn
Copy link
Member

blckmn commented Aug 13, 2023 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

McGiverGim
McGiverGim reviewed Aug 14, 2023
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2023

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@lipskij lipskij requested a review from McGiverGim August 27, 2023 13:41
@haslinghuis haslinghuis merged commit 5bb8207 into betaflight:master Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chmelevskij chmelevskij chmelevskij approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

@McGiverGim McGiverGim Awaiting requested review from McGiverGim

Assignees

@lipskij lipskij

Labels

RN: UI

Projects

Finalizing Firmware 4.5 Release
Status: COMPLETED

Milestone

10.10.0

Development

Successfully merging this pull request may close these issues.

5 participants

@lipskij @blckmn @McGiverGim @chmelevskij @haslinghuis