Skip to content

GPS tab with same design for lat / lon as on Setup tab #3516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2023
Merged

GPS tab with same design for lat / lon as on Setup tab #3516

merged 1 commit into from
Jul 30, 2023

Conversation

@HThuren
Copy link
Member

@HThuren HThuren commented Jul 18, 2023 •
edited
Loading

Small design change to
image

was before
image

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2023

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis added this to the 10.10.0 milestone Jul 18, 2023
@blckmn
Copy link
Member

blckmn commented Jul 18, 2023 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

nerdCopter
nerdCopter approved these changes Jul 29, 2023
View reviewed changes
Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • approving untested; visual inspection only

@haslinghuis
Copy link
Member

haslinghuis commented Jul 29, 2023

@HThuren Screenshot on smaller screen (1366x768) on setup tab seems to need some adjustment:

image

@haslinghuis haslinghuis merged commit 4087f0c into betaflight:master Jul 30, 2023
@HThuren
Copy link
Member Author

HThuren commented Jul 30, 2023 •
edited
Loading

@HThuren Screenshot on smaller screen (1366x768) on setup tab seems to need some adjustment:

image

I can remove the dobbel unit (deg) like: "47.4919 / 19.0540 deg" ?

@HThuren HThuren deleted the fixGPStab branch September 4, 2023 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haslinghuis haslinghuis haslinghuis approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

@McGiverGim McGiverGim Awaiting requested review from McGiverGim

Assignees

@HThuren HThuren

Labels

RN: UI

Projects

Finalizing Firmware 4.5 Release
Status: COMPLETED

Milestone

10.10.0

Development

Successfully merging this pull request may close these issues.

4 participants

@HThuren @blckmn @haslinghuis @nerdCopter