-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Disable search in multiple select field for Other Options field when not selected #3500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
This comment has been minimized.
This comment has been minimized.
|
AUTOMERGE: (FAIL)
|
|
This disables the search? I use it a lot, each time I need to add some define. |
|
@McGiverGim yes - but I only want to stop enabling typing in the field. Maybe Vue has a better way (as I don't want to extend with adapters). |
|
i also use the search, then click the filtered result. |
|
Agree we should not be able to type in the result, only using search. Also often end up typing in the options field when using custom defines field. |
|
I don't remove the text. When you search, yes, it remains in the field, but it seems is not "really" there. It seems not to affect the build, only the selected ones. |
4eb793c to
fa95e91
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
It would be better if we could have a search box separate from the selected items as backspace will remove last selected. |
|
Do you want to test this code? Here you have an automated build: |
i'd be okay with backspace deletion if the cursor could be moved with keyboard. arrow keys do not move cursor :( edit: seems the whole UI requires mousing only. tabbing between fields is barely functional across the whole UI too. very not computer-centric. |
nerdCopter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fa95e911 seems to clear the typing upon field exit; approving.








Fixes #3457
We should not be able to type here - this part is still there - but disabling also disable the search. Disabling on field exit seems to fix the issue jumping back from typing in Custom Defines to Other Options field.