Skip to content

Fix offline behavior #3480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 13, 2023
Merged

Fix offline behavior #3480

merged 2 commits into from
Jun 13, 2023

Conversation

@haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Jun 11, 2023 •
edited
Loading

When offline obvious we cannot query cloud api - falling back to normal operation.

Thanks to @ASDosjani for bringing this up.

@haslinghuis haslinghuis added this to the 10.10.0 milestone Jun 11, 2023
@haslinghuis haslinghuis self-assigned this Jun 11, 2023
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis force-pushed the fix-offline branch 4 times, most recently from 3e0b00c to 9ce88da Compare June 11, 2023 17:22
@github-actions

This comment has been minimized.

Sign in to view
@blckmn
Copy link
Member

blckmn commented Jun 11, 2023 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> PASS
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@nerdCopter
Copy link
Member

nerdCopter commented Jun 12, 2023

inaccurate text, but works as expected.
offline

@haslinghuis
Copy link
Member Author

haslinghuis commented Jun 12, 2023

image

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Jun 12, 2023

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis requested review from McGiverGim and blckmn June 13, 2023 11:48
@haslinghuis haslinghuis merged commit 791751a into betaflight:master Jun 13, 2023
@haslinghuis haslinghuis deleted the fix-offline branch June 13, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blckmn blckmn blckmn approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

@McGiverGim McGiverGim Awaiting requested review from McGiverGim

Assignees

@haslinghuis haslinghuis

Labels

Ready to Merge RN: BUGFIX Tested

Projects

Finalizing Firmware 4.5 Release
Status: COMPLETED

Milestone

10.10.0

Development

Successfully merging this pull request may close these issues.

3 participants

@haslinghuis @blckmn @nerdCopter