Skip to content

Move mDNS initialization #3412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2023
Merged

Move mDNS initialization #3412

merged 1 commit into from
Apr 9, 2023

Conversation

@haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Apr 9, 2023

Initialization should only take place when option is enabled

@haslinghuis haslinghuis added this to the 10.10.0 milestone Apr 9, 2023
@haslinghuis haslinghuis self-assigned this Apr 9, 2023
@github-actions

This comment has been minimized.

Sign in to view
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2023

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn
Copy link
Member

blckmn commented Apr 9, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis merged commit ef40e88 into betaflight:master Apr 9, 2023
@haslinghuis haslinghuis deleted the fix-mdns-init branch April 9, 2023 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blckmn blckmn blckmn approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

Assignees

@haslinghuis haslinghuis

Labels

RN: BUGFIX

Projects

Finalizing Firmware 4.5 Release
Status: COMPLETED

Milestone

10.10.0

Development

Successfully merging this pull request may close these issues.

3 participants

@haslinghuis @blckmn @nerdCopter