Skip to content

Fix PID tab #3399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2023
Merged

Fix PID tab #3399

merged 1 commit into from
Apr 5, 2023

Conversation

@haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Apr 3, 2023

Fixes: #3354

Intermittent issue seems to be in the THREE library

image

See: pmndrs/react-three-fiber#1004 (comment)

@haslinghuis haslinghuis added this to the 10.10.0 milestone Apr 3, 2023
@haslinghuis haslinghuis self-assigned this Apr 3, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn
Copy link
Member

blckmn commented Apr 3, 2023 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> PASS
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis merged commit 9db6806 into betaflight:master Apr 5, 2023
@haslinghuis haslinghuis deleted the fix-pid-tab branch April 5, 2023 11:56
@haslinghuis haslinghuis mentioned this pull request Feb 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@McGiverGim McGiverGim McGiverGim approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

Assignees

@haslinghuis haslinghuis

Labels

RN: BUGFIX Tested

Projects

Finalizing Firmware 4.5 Release
Status: COMPLETED

Milestone

10.10.0

Development

Successfully merging this pull request may close these issues.

betaflight-configurator_10.9.0_amd64.deb

4 participants

@haslinghuis @blckmn @McGiverGim @nerdCopter