Skip to content

FIX: Adjusting setting of ajax default header as not being passed for version check #3383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2023
Merged

FIX: Adjusting setting of ajax default header as not being passed for version check #3383

merged 1 commit into from
Mar 18, 2023

Conversation

@blckmn
Copy link
Member

@blckmn blckmn commented Mar 18, 2023

The version check was occurring before the default ajax header was being set. This resulted in a "non-current" return, because the header was missing.

@blckmn blckmn self-assigned this Mar 18, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.0% 1.0% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Mar 18, 2023

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn blckmn added this to the 10.10.0 milestone Mar 18, 2023
@blckmn
Copy link
Member Author

blckmn commented Mar 18, 2023 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

nerdCopter
nerdCopter approved these changes Mar 18, 2023
View reviewed changes
Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • approving untested.

@haslinghuis haslinghuis merged commit e94cb0c into betaflight:master Mar 18, 2023
@blckmn blckmn deleted the version-check branch March 20, 2023 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haslinghuis haslinghuis haslinghuis approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

Assignees

@blckmn blckmn

Labels

RN: BUGFIX

Projects

Finalizing Firmware 4.5 Release
Status: COMPLETED

Milestone

10.10.0

Development

Successfully merging this pull request may close these issues.

3 participants

@blckmn @haslinghuis @nerdCopter