Skip to content

Conversation

@atomgomba
Copy link
Contributor

@atomgomba atomgomba commented Feb 23, 2023

This PR adds a new option to automatically open DevTools in debug mode. In release mode the option is hidden.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn
Copy link
Member

blckmn commented Feb 23, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@nerdCopter
Copy link
Member

nerdCopter commented Mar 2, 2023

This is nice.

  • I notice that it only opens upon startup. It is possible to open/close immediately upon toggle? if yes, then the toggle name could simply be "Open DevTools" and trigger in both cases (toggle/startup)
  • Could this toggle only be visible when it is a debug-build?

@blckmn blckmn merged commit 6abcce2 into betaflight:master Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: COMPLETED

Development

Successfully merging this pull request may close these issues.

4 participants