replaceAll-workaround #3348

haslinghuis · 2023-02-19T01:35:20Z

Fixes an issue on Cordova Android

Credit to @semics https://stackoverflow.com/a/72049058
Tested by: @rabbitambulance-ra

Co-authored-by: @nerdCopter [email protected]

blckmn · 2023-02-19T04:17:04Z

AUTOMERGE: (FAIL)

github identifies PR as mergeable -> FAIL
assigned to a milestone -> PASS
cooling off period lapsed -> PASS
commit count less or equal to three -> PASS
Don't merge label NOT found -> PASS
at least one RN: label found -> PASS
Tested label found -> PASS
assigned to an approver -> PASS
approver count at least three -> FAIL

nerdCopter · 2023-02-19T15:52:04Z

Should this be limited to Android only?
maybe something like

    if (/android/i.test(userAgent)) {
        [code]
    }

nerdCopter · 2023-02-19T16:59:30Z

Didn't seem to break anything on Linux, but only lightly tested. Might prefer limiting to Android just in case as stated above.

haslinghuis · 2023-02-19T17:15:42Z

Yes tried yesterday on line 187 - adding now.

userAgent is not defined :)

nerdCopter · 2023-02-19T21:57:16Z

Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android

I was able to use it on an Android 9 (Jan 2020) phone. Basic PIDs/Ports/CLI tabs. Did not test others.
EDIT: latest "nightly" worked as well, so not a fair test.

chmelevskij · 2023-02-22T14:02:12Z

src/js/main.js

+if (/android/i.test(navigator.userAgent)) {
+    if (typeof String.prototype.replaceAll === "undefined") {
+        String.prototype.replaceAll = function(match, replace) {
+            return this.replace(new RegExp(match, 'g'), () => replace);
+        };
+    }
+}


I don't think we need that android test tbh. typeof sort of covers all the required bases imo.

thank you; sounds fair. if that's the case @haslinghuis can revert and it can just be merged since it was tested the other way already,

sonarqubecloud · 2023-02-22T14:22:35Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

github-actions · 2023-02-22T14:34:21Z

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

haslinghuis added the RN: BUGFIX label Feb 19, 2023

haslinghuis added this to the 10.10.0 milestone Feb 19, 2023

haslinghuis self-assigned this Feb 19, 2023

haslinghuis force-pushed the fix-replaceall branch 2 times, most recently from cb0bdb1 to 05fb3b9 Compare February 19, 2023 01:44