Skip to content

Fix telemetry being disabled for protocols used outside of ports tab #3298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2023
Merged

Fix telemetry being disabled for protocols used outside of ports tab #3298

merged 1 commit into from
Jan 31, 2023

Conversation

@haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Jan 31, 2023

No description provided.

@haslinghuis haslinghuis added this to the 10.10.0 milestone Jan 31, 2023
@haslinghuis haslinghuis self-assigned this Jan 31, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2023

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn
Copy link
Member

blckmn commented Jan 31, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@LoakAudio
Copy link

LoakAudio commented Jan 31, 2023

Hi all, tested with the linux portable version : no more Telemetry vanishing when playing with Ports tab.
Thanks gentlemen.

@haslinghuis haslinghuis merged commit 8b6f3bb into betaflight:master Jan 31, 2023
@haslinghuis haslinghuis deleted the fix-telemetry branch January 31, 2023 15:52
@haslinghuis haslinghuis mentioned this pull request Mar 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@klutvott123 klutvott123 klutvott123 approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

@McGiverGim McGiverGim Awaiting requested review from McGiverGim

Assignees

@haslinghuis haslinghuis

Labels

RN: BUGFIX

Projects

Finalizing Firmware 4.5 Release
Status: COMPLETED

Milestone

10.10.0

Development

Successfully merging this pull request may close these issues.

5 participants

@haslinghuis @blckmn @LoakAudio @klutvott123 @nerdCopter