-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Fixed gems not being in PATH #3373 && permission issues #3374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- as referenced at issue beefproject#3373 gems werent being added to path after being installed automatically since the bundle gem was referenced/called right after that in the install script it caused the script to crash ok fixed this and other permission issues that were occurring due to specific user paths and permissions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes permission and PATH issues when installing Ruby gems for BeEF, specifically addressing issue #3373. The changes ensure gems are installed to user directories instead of system locations and properly configure the PATH to make bundle commands available.
- Refactored bundler detection to use a separate command availability check function
- Added automatic PATH configuration for user gem directories when bundle command is not found
- Modified gem installation to use user-specific gem paths instead of system directories
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Stale pull request message |
|
Hi @erdajt , thanks for this PR. Could you please review the Copilot suggested changes and accept them if they make sense or reject with the justification? Also, it would be helpful to know the Arch version you this is happening in as I will need to setup a VM for myself to reproduce the issue and see that your fix has solved it. |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
sure, i applied the suggestions, need to have a second look again whenever i have the time 6.16.10-arch1-1 x86_64 |
Pull Request: Fix BeEF installer permission and PATH issues
Category
Bug
Feature/Issue Description
Permission errors when installing gems to system directories (Ruby gems not added to PATH #3373)
PATH configuration for Bundler executables after gem installation
as referenced at issue #3373 gems werent being added to path after being installed automatically since the bundle gem was referenced/called right after that in the install script it caused the script to crash ok
fixed this and other permission issues that were occurring due to specific user paths and permissions
Instead of installing gems to system directories (which requires root), we now install to the user's gem directory by:
BUNDLE_PATHto the user's gem directoryTest Cases
Same case as #3373 now fixed
It successfully adds the Gems to PATH and installation is complete