Skip to content

PRIME-2735 Admin can edit HA Care Type Vendor mapping #2518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

PRIME-2735 Admin can edit HA Care Type Vendor mapping #2518

wants to merge 15 commits into from

Conversation

@bergomi02
Copy link
Collaborator

@bergomi02 bergomi02 commented May 31, 2024

No description provided.

@bergomi02 bergomi02 added Frontend Updates to the frontend of the application Backend Updates to the backend of the application Ready For Review PR is ready for code review Database labels May 31, 2024
@bergomi02 bergomi02 requested a review from neophyte57 May 31, 2024 22:11
@bergomi02 bergomi02 self-assigned this May 31, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 21, 2024
View reviewed changes
@bergomi02 bergomi02 force-pushed the feature/prime-2735_ha_care_type_vendor_page branch from 8692b4a to cf894f6 Compare June 28, 2024 18:04
@neophyte57
Copy link
Contributor

neophyte57 commented Mar 7, 2025

Testing this locally, I have these Care Types and Vendors
image

But can't seem to associate a Vendor to the new Care Type "Funny Care"?
image

@bergomi02
Copy link
Collaborator Author

bergomi02 commented Mar 11, 2025

Testing this locally, I have these Care Types and Vendors image

But can't seem to associate a Vendor to the new Care Type "Funny Care"? image

Good catch. it should be fixed.

neophyte57
neophyte57 reviewed Mar 11, 2025
View reviewed changes
...dication/pages/health-authorities/care-type-vendor-page/care-type-vendor-page.component.html
<app-page-subheader>
<ng-container appPageSubheaderTitle>{{ title }}</ng-container>
<ng-container appPageSubheaderSummary>
Identify the Care Type Vendor associated with this Health Authority.
Copy link
Contributor

@neophyte57 neophyte57 Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest changing to "Identify the Vendor(s) associated with each Care Type."

@neophyte57
Copy link
Contributor

neophyte57 commented Mar 12, 2025

Testing locally ... when "Funny Care" was associated with CareConnect, I started a HA Site submission. But then, as admin, I switched Funny Care to BDM
image

However, now for the Site, I can "Save and Continue" without selecting any Vendor:
image

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 27, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@neophyte57 neophyte57 neophyte57 left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@bergomi02 bergomi02

Labels

Backend Updates to the backend of the application Database Frontend Updates to the frontend of the application Ready For Review PR is ready for code review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bergomi02 @neophyte57